Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests relating to python support should be avoided if ledger is built without python support #2324

Open
Earnestly opened this issue Jan 16, 2024 · 3 comments
Assignees
Labels
python Related to the Python API tests Related to ledger's test suite

Comments

@Earnestly
Copy link

I build ledger with -D USE_PYTHON=OFF but the python specific tests are still executed during make check resulting in several test failures:

The following tests FAILED:
         47 - BaselineTest_dir-import_py (Failed)
         49 - BaselineTest_dir-python_py (Failed)
         59 - BaselineTest_feat-import_py (Failed)
         60 - BaselineTest_feat-option_py (Failed)
         62 - BaselineTest_feat-value_py (Failed)
        311 - RegressTest_4D9288AE_py (Failed)
        349 - RegressTest_78AB4B87_py (Failed)
        362 - RegressTest_9188F587_py (Failed)
        379 - RegressTest_B21BF389_py (Failed)
        423 - RegressTest_xact_code_py (Failed)

Should these tests either not be run or set to be expected failure?

@afh afh self-assigned this Jan 16, 2024
@afh afh added python Related to the Python API tests Related to ledger's test suite labels Jan 16, 2024
@afh
Copy link
Member

afh commented Jan 16, 2024

Thanks for raising this, @Earnestly, I think these tests should be omitted when Ledger is built without Python support. I'll look into preparing an appropriate PR and will cc you on it if you don't mind…

afh added a commit to afh/ledger that referenced this issue Jan 17, 2024
@afh
Copy link
Member

afh commented Jan 17, 2024

#2325 is now up for review, @Earnestly, would you be willing to test the proposed changes in the PR and see if they fix this issue for you too?

@Earnestly
Copy link
Author

Applied #2325 locally and it appears to be working:

100% tests passed, 0 tests failed out of 413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to the Python API tests Related to ledger's test suite
Projects
None yet
Development

No branches or pull requests

2 participants