Fix missing suffix for completion form elements

dlmsr · Hoang, Minh Duc · dlmsr · commit 2ebf5ff95021 · 2025-09-03T20:04:22.000+02:00
The module name needs to be appended to the custom completion form
elements.

Co-authored-by: Hoang, Minh Duc &lt;minh-duc.hoang@fernuni-hagen.de&gt;
diff --git a/mod_form.php b/mod_form.php
@@ -376,8 +376,7 @@ public function add_completion_rules() {
      * @return string
      */
     protected function get_suffixed_name(string $fieldname): string {
-        // Counterintuitively don't use function get_suffix(), since data isn't saved correctly in DB otherwise.
-        return 'completion' . $fieldname;
+        return "completion{$fieldname}_{$this->get_suffix()}";
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -376,8 +376,7 @@ public function add_completion_rules() {`
`376`	`376`	`* @return string`
`377`	`377`	`*/`
`378`	`378`	`protected function get_suffixed_name(string $fieldname): string {`
`379`		`- // Counterintuitively don't use function get_suffix(), since data isn't saved correctly in DB otherwise.`
`380`		`- return 'completion' . $fieldname;`
	`379`	`+ return "completion{$fieldname}_{$this->get_suffix()}";`
`381`	`380`	`}`
`382`	`381`
`383`	`382`	`/**`