add new cover annotations

Author: TamaroWalter

CHANGES.md

@@ -1,7 +1,6 @@
 CHANGELOG
 =========
 
-v5.0-r1 (2025-07-02) 
+v5.0-r1 (2025-07-02)
 ------------------
-- [FIX] Issue #322
-- Moves classes from `locallib.php` to own class files.
+- [FIX] Issue [#322}(https://github.com/learnweb/moodle-mod_ratingallocate/issues/322)

classes/ratingallocate.php

@@ -211,7 +211,7 @@ private function process_action_start_distribution() {
                 raise_memory_limit(MEMORY_EXTRA);
                 core_php_time_limit::raise();
                 // Distribute choices.
-                $timeneeded = $this->distrubute_choices();
+                $timeneeded = $this->distribute_choices();
 
                 // Logging.
                 $event = distribution_triggered::create_simple(
@@ -1352,7 +1352,7 @@ public function get_ratings_for_rateable_choices() {
      * distribution of choices for each user
      * take care about max_execution_time and memory_limit
      */
-    public function distrubute_choices() {
+    public function distribute_choices() {
         require_capability('mod/ratingallocate:start_distribution', $this->context);
 
         // Set algorithm status to running.
@@ -1455,11 +1455,8 @@ public function synchronize_allocation_and_grouping() {
             $groupids = $this->db->get_record(this_db\ratingallocate_ch_gengroups::TABLE,
                 ['choiceid' => $choiceid],
                 'groupid');
-            if ($groupid = $groupids->groupid) {
-                $group = groups_get_group($groupid);
-                if ($group) {
-                    groups_add_member($group, $userid);
-                }
+            if (($groupid = $groupids->groupid) && ($group = groups_get_group($groupid))) {
+                groups_add_member($group, $userid);
             }
         }
         // Invalidate the grouping cache for the course.

classes/task/cron_task.php

@@ -80,7 +80,7 @@ public function execute() {
                 // Clear eventually scheduled distribution of unallocated users.
                 $ratingallocate->clear_distribute_unallocated_tasks();
                 // Run allocation.
-                $ratingallocate->distrubute_choices();
+                $ratingallocate->distribute_choices();
             }
         }
         return true;

tests/backup_restore_test.php

@@ -36,7 +36,7 @@
  * @group      mod_ratingallocate
  * @copyright  usener
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- * @covers     \mod_ratingallocate\backup_ratingallocate_activity_structure_step
+ * @covers     \mod_ratingallocate\backup_ratingallocate_activity_structure_step (This is deprecated from phpunit 12 onwards)
  */
 #[CoversClass(backup_ratingallocate_activity_structure_step::class)]
 final class backup_restore_test extends \advanced_testcase {

tests/cron_test.php

@@ -24,6 +24,7 @@
 use mod_ratingallocate\db as this_db;
 use mod_ratingallocate\task\cron_task;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\CoversFunction;
 
 /**
  * mod_ratingallocate cron tests
@@ -39,6 +40,7 @@
  * @covers \mod_ratingallocate\task\cron_task
  */
 #[CoversClass(cron_task::class)]
+#[CoversFunction('execute')]
 final class cron_test extends \advanced_testcase {
 
     /** @var $teacher */
@@ -131,7 +133,7 @@ private function run_cron() {
     /**
      * Assert, that the algorithm status is not_started and the algorithm has created no allocation.
      */
-    private function assert_not_started() {
+    private function assert_not_started(): void {
         global $DB;
         $record = $DB->get_record(this_db\ratingallocate::TABLE, []);
         $ratingallocate = \mod_ratingallocate_generator::get_ratingallocate_for_user($this, $record, $this->teacher);
@@ -143,7 +145,7 @@ private function assert_not_started() {
     /**
      * Assert, that the algorithm status is running and the algorithm has created no allocation.
      */
-    private function assert_running() {
+    private function assert_running(): void {
         global $DB;
         $record = $DB->get_record(this_db\ratingallocate::TABLE, []);
         $ratingallocate = \mod_ratingallocate_generator::get_ratingallocate_for_user($this, $record, $this->teacher);
@@ -155,7 +157,7 @@ private function assert_running() {
     /**
      * Assert, that the algorithm status is failure and the algorithm has created no allocation.
      */
-    private function assert_failure() {
+    private function assert_failure(): void {
         global $DB;
         $record = $DB->get_record(this_db\ratingallocate::TABLE, []);
         $ratingallocate = \mod_ratingallocate_generator::get_ratingallocate_for_user($this, $record, $this->teacher);
@@ -167,7 +169,7 @@ private function assert_failure() {
     /**
      * Assert, that the algorithm status is finished and the algorithm has created 4 allocations.
      */
-    private function assert_finish() {
+    private function assert_finish(): void {
         global $DB;
         $record = $DB->get_record(this_db\ratingallocate::TABLE, []);
         $ratingallocate = \mod_ratingallocate_generator::get_ratingallocate_for_user($this, $record, $this->teacher);
@@ -179,7 +181,7 @@ private function assert_finish() {
     /**
      * Assert, that the algorithm status is still finished and the algorithm has created no allocation.
      */
-    private function assert_already_finish() {
+    private function assert_already_finish(): void {
         global $DB;
         $record = $DB->get_record(this_db\ratingallocate::TABLE, []);
         $ratingallocate = \mod_ratingallocate_generator::get_ratingallocate_for_user($this, $record, $this->teacher);
@@ -195,7 +197,7 @@ private function assert_already_finish() {
      * @param int $algorithmstarttime the start time of the algorithm.
      */
     private function create_ratingallocate($ratingperiodended,
-                                           $algorithmstatus = algorithm_status::NOTSTARTED, $algorithmstarttime = null) {
+                                           $algorithmstatus = algorithm_status::NOTSTARTED, $algorithmstarttime = null): void {
         global $DB;
 
         $this->resetAfterTest();

tests/generator/lib.php

@@ -423,7 +423,7 @@ public function __construct(advanced_testcase $tc, $moduledata = null, $choiceda
         // Allocate choices.
         $ratingallocate = mod_ratingallocate_generator::get_ratingallocate_for_user($tc,
                 $this->moddb, $this->teacher);
-        $timeneeded = $ratingallocate->distrubute_choices();
+        $timeneeded = $ratingallocate->distribute_choices();
         $tc->assertGreaterThan(0, $timeneeded);
         $tc->assertLessThan(2.0, $timeneeded, 'Allocation is very slow');
         $this->allocations = $ratingallocate->get_allocations();