Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preview in settings #25

Open
OlenaTatarintseva opened this issue Oct 7, 2019 · 3 comments
Open

Add a preview in settings #25

OlenaTatarintseva opened this issue Oct 7, 2019 · 3 comments

Comments

@OlenaTatarintseva
Copy link

OlenaTatarintseva commented Oct 7, 2019

Edited as per #25 (comment):

When settings are changed, particularly the logo upload, add two previews of what QR codes will look like. This allows admins to check whether the codes will look as intended. In particular, it may not be obvious from the start that there is a default logo, and that uploading just a single format type will not have an impact on all QR codes! A preview would make this more apparent.

--------- original text -------------

Hello,

Thanks for your work on this plugin.

It would be nice to add the QR code image reloading on format selecting. It is not clear for user, how it will looks like, when he/she is trying to download the png file. The image on png file could be different, because there is the possibility in the plugin settings to use different image for each format.

Best regards,
Olena Tatarintseva

@Dagefoerde
Copy link
Contributor

Hi, thanks for sharing your idea. However, I would strongly suggest using logo images that look identical, regardless of the format. The case that you describe sounds to me like the plugin was misconfigured by using different images. In the browser, we strictly use the SVG format as it offers the best resolution in any environment.

Your suggestion leads to my idea that we could show a preview while configuring the block so that an administrator can see whether both images actually look identical. What do you think?

@OlenaTatarintseva
Copy link
Author

I think that's a good idea, especially when adding an image, I've noticed that the .svg filemanager holds 'default' image that is 'hidden', so when the admin/teacher adds a .png image, he may not be aware of the fact that .svg already exists and it's different. I hope this makes sense.

@Dagefoerde Dagefoerde changed the title Image reloading on format selecting. Add a preview in settings Oct 11, 2019
@Dagefoerde
Copy link
Contributor

It does make sense indeed. Thanks for your feedback! I took the liberty of changing title and description of the issue to reflect this.

We will put this on our backlog. As usual, please feel free to help. If you can provide a patch, please create a pull request that we will be happy to review. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants