-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very interesting repro - any chance it will be maintained? ... as of now it has 4 vulnerabilities #4
Comments
As of now - just following your instructions
and then running the suggested command is resulting in
and running the suggested command again
The command attempted to fix the vulnerabilities, including the high severity issue with path-to-regexp, by updating @clerk/nextjs to version 4.6.18. However, the update was a breaking change and from there it was a down hill of failures 👎 👎 👎
NOTE: See "Next.js (14.2.3) out of date (learn more)" - I guess the repo needs some TLC and active maintenance 👍 |
Hi @leandroercoli - I am very excited to find your repo and I feel it has a lot of potential - do you plan to actively maintain it?
If yes ... here are two thoughts
At the min It needs unit tests - even if it is just to validate that primary functionality is still working as you upgrade dependencies. For anyone wanting to embrace and leverage it in production with peace of mind, tests are essential.
Not everyone needs all features - so one needs to be able to disable/enable just the features they need. For example, Saasterkit is currently forcing users to have a LemonSqueezy account but some of them may not want to put in payment systems until they find/reach PMF (Product Market Fit).
Looking forward to hearing back from you
Regards,
-Avi
The text was updated successfully, but these errors were encountered: