Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with 'offset_top' #58

Open
GGKenChi opened this issue Jun 22, 2014 · 8 comments
Open

problem with 'offset_top' #58

GGKenChi opened this issue Jun 22, 2014 · 8 comments

Comments

@GGKenChi
Copy link

offset_top is set (~60px)

If the content is about the same size as the window size:

  • the bottom of the content will be cut down (position: fixed) and will not be visible (~30px)

(container.height > content.height, container.height = sidebar.height > content.height)

@GGKenChi
Copy link
Author

demonstration:
http://kenchi.hu/sticky-kit/

@GGKenChi
Copy link
Author

GGKenChi commented Jul 2, 2014

if (inner_scrolling) {
win_height = win.height();
if (height > win_height) {

change:

if (inner_scrolling) {
win_height = win.height();
if (height + offset_top > win_height) {

"+ offset_top" added

@cphoover
Copy link

+1

@cphoover
Copy link

Just submitted a PR for this fix #63

@MoonlightMultimedia
Copy link

I have noticed the same issue and can confirm that the change by GGKenChi fixes it.

@zeldi-dev
Copy link

I have issues with cphoover&GGKenChi's fix. After applying a fix, sticky element jumps to its absolute bottom position, when comming close to an end.

@MoonlightMultimedia
Copy link

@zevnikrok Make sure you trigger the recalc event when dynamically editing the contents on your page/app.

@devolkpl
Copy link

Thanks, @GGKenChi that works for me. Please update package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants