Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE] [LABS] Adapters name is not matching on various instructions #51

Closed
asubedy opened this issue Dec 29, 2021 · 10 comments · Fixed by #62 · May be fixed by #56
Closed

[WEBSITE] [LABS] Adapters name is not matching on various instructions #51

asubedy opened this issue Dec 29, 2021 · 10 comments · Fixed by #62 · May be fixed by #56
Labels
issue/stale Issue has not had any activity for an extended period of time kind/bug Something isn't working kind/chore Necessary task

Comments

@asubedy
Copy link
Member

asubedy commented Dec 29, 2021

Description
There are instances where a different adapter name is used in between the instruction of a different adapter. This might confuse people and further create problems to complete the lab. Attached is an example of what I am talking about. Need to change this mismatch on all the adapters that have this mistake.

Expected Behavior
The adapter name should be set correctly on the instruction.

Screenshots
Screen Shot 2021-12-29 at 17 42 15
.

Environment:

  • Host OS: macOS
  • Browser: Brave, Safari

Contributor Resources

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

@ghost ghost assigned asubedy Dec 29, 2021
@welcome
Copy link

welcome bot commented Dec 29, 2021

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@leecalcote leecalcote transferred this issue from layer5io/layer5 Dec 29, 2021
@leecalcote leecalcote added kind/chore Necessary task kind/bug Something isn't working labels Dec 30, 2021
@leecalcote
Copy link
Member

So good of you to open up this issue, @asubedy

@asubedy
Copy link
Member Author

asubedy commented Dec 30, 2021

@leecalcote the labs' screenshot seems to be outdated and does not match with the current meshery UI. The instructions too seem to be pointing to older text. Should I update these all in this issue only?

@leecalcote
Copy link
Member

@asubedy, yes, that'll work. The updates can be grouped together.

@asubedy
Copy link
Member Author

asubedy commented Dec 30, 2021

Yes, all right will be doing that too. 🚀

@stale
Copy link

stale bot commented Feb 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Feb 26, 2022
@stale
Copy link

stale bot commented Mar 9, 2022

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Mar 9, 2022
@leecalcote leecalcote removed the issue/stale Issue has not had any activity for an extended period of time label Mar 9, 2022
@leecalcote leecalcote reopened this Mar 9, 2022
@leecalcote
Copy link
Member

@asubedy are we all clear here (done)?

@stale
Copy link

stale bot commented Apr 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 24, 2022
@stale
Copy link

stale bot commented May 5, 2022

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time kind/bug Something isn't working kind/chore Necessary task
2 participants