Add whitespace ignoring #116
Conversation
glconti
force-pushed
the
add-whitespace-ignoring
branch
from
cffd333
to
3456f44
Compare
GitDiffMargin/Git/HunkRange.cs
Outdated
| @@ -2,20 +2,19 @@ namespace GitDiffMargin.Git | |||
| { | |||
| public class HunkRange | |||
| { | |||
| public HunkRange(string hunkRange, int contextLines) | |||
There was a problem hiding this comment.
Why removing the contextLines?
There was a problem hiding this comment.
It was always 0, while learning the code it made sense, do you fell like could it be useful in the future?
There was a problem hiding this comment.
Yes in the future I wanted to introduce a possibility to define some value for it, which would be useful here
There was a problem hiding this comment.
✅ restored context line parameter
glconti
force-pushed
the
add-whitespace-ignoring
branch
from
3456f44
to
71752d4
Compare
glconti
force-pushed
the
add-whitespace-ignoring
branch
from
71752d4
to
5940e3a
Compare
|
Having the new button on the contextual menu is confusing because you tend to think that it applies only to this hunk when it applies to the whole file I think it would be better to have it only on the menu bar |
|
When ignoring whitespace is on and a white space is added at the limit of a hunk, it shows changes which it should not do
|
This change is