Note list: Slower to update in version 2.14 and 3.0 than 2.13

[personalizedrefrigerator]

Operating system

Linux

Joplin version

3.0.2

Desktop version info

Joplin 3.0.2 (dev, linux)

Client ID: 5cd73fa94f1c4847a76b5ee095980929
Sync Version: 3
Profile Version: 46
Keychain Supported: No

Revision: b3f4414

Backup: 1.4.1

Current behaviour

See https://discourse.joplinapp.org/t/performance-issue/37207/19

In Joplin 2.14+, the note list takes several seconds to update its sorting, while in Joplin 2.13, it was very fast.

note-list-demo.mp4

Expected behaviour

The note list sorting should update quickly in Joplin 2.14 and Joplin 3.0, as it did in Joplin 2.13.

Logs

No response

[personalizedrefrigerator]

Likely related to/a duplicate of #10203

[HahaBill]

First of all, great bug report! I will have a look and tell you what I've discovered.

[HahaBill]

Alright, I got an update: The problem seems to be in the NOTE_SORT, where there is a timeout of 2 seconds in sortNoteListTimeout. I changed it to 0 seconds, and it was immediately fast and solved the issue! However, in the comments, the purpose of this delay was stated.

if (sortNoteList) {
		if (sortNoteListTimeout) shim.clearTimeout(sortNoteListTimeout);
		sortNoteListTimeout = null;

		// We sort the note lists with two seconds debounce because doing can be
		// very slow and would have to be done every time a note is added.
		if (Date.now() - newState.noteListLastSortTime > 10000) {
			dispatch({ type: 'NOTE_SORT' });
		} else {
			sortNoteListTimeout = shim.setTimeout(() => {
				sortNoteListTimeout = null;
				dispatch({ type: 'NOTE_SORT' });
			}, 2000);
		}
	}

[HahaBill]

Alright, I got an update: The problem seems to be in the NOTE_SORT, where there is a timeout of 2 seconds in sortNoteListTimeout. I changed it to 0 seconds, and it was immediately fast and solved the issue! However, in the comments, the purpose of this delay was stated.

if (sortNoteList) {
		if (sortNoteListTimeout) shim.clearTimeout(sortNoteListTimeout);
		sortNoteListTimeout = null;

		// We sort the note lists with two seconds debounce because doing can be
		// very slow and would have to be done every time a note is added.
		if (Date.now() - newState.noteListLastSortTime > 10000) {
			dispatch({ type: 'NOTE_SORT' });
		} else {
			sortNoteListTimeout = shim.setTimeout(() => {
				sortNoteListTimeout = null;
				dispatch({ type: 'NOTE_SORT' });
			}, 2000);
		}
	}

Oh and one more thing. NOTE_SORT is used for both notes and to-dos, that also explains the #10203