Skip to content

Overzealous string masking #111

@davidferlay

Description

@davidferlay

Observed

  • Following Shell runtime, forked process env var and sensitive strings masking. #89 sensitive credentials from keyring are masked from output of actions
  • It does have an unexpected effect on action where are specifically made to deal with credentials, such as plasmactl platform:vault edit platform/group_vars/platform/vault.yaml which opens vault file using ansible cli but leads to:

Image

Expected

  • In some cases, credentials contained in keyring or used as input of action should not trigger masking

Todo

  • Look for a way to unmask credentials for action where we specifically need them to be displayed
  • Maybe a list of action id to be excluded from masking could be added in config, or have an option available to prevent string masking

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions