Fix the review comments from Prashanth.

Author: linmagit

.clang-format

@@ -8,3 +8,9 @@ TabWidth: 2
 
 # No tabs
 UseTab: Never
+
+# Don't automatically derive the alignment of & and *
+DerivePointerAlignment: false
+
+# Always align pointer and reference to the right
+PointerAlignment: Right

src/binder/bind_node_visitor.cpp

@@ -203,7 +203,7 @@ void BindNodeVisitor::Visit(expression::FunctionExpression *expr) {
   // we have to do the string comparison to find out the corresponding
   // DatePartType when scanning every tuple.
   auto func_name = expr->GetFuncName();
-  if (func_name == "date_trunc" or func_name == "extract") {
+  if (func_name == "date_trunc" || func_name == "extract") {
     // Check the type of the first argument. Should be VARCHAR
     auto date_part = expr->GetChild(0);
     if (date_part->GetValueType() != type::TypeId::VARCHAR) {

src/codegen/type/integer_type.cpp

@@ -377,6 +377,8 @@ struct Modulo : public TypeSystem::BinaryOperator {
 };
 
 // DateTrunc
+// TODO(lma): Move this to the Timestamp type once the function lookup logic is
+// corrected.
 struct DateTrunc : public TypeSystem::BinaryOperator {
   bool SupportsTypes(const Type &left_type,
                      const Type &right_type) const override {