Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Extra" option with more out-of-the-box #22

Open
imliam opened this issue May 9, 2020 · 3 comments
Open

"Extra" option with more out-of-the-box #22

imliam opened this issue May 9, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@imliam
Copy link
Contributor

imliam commented May 9, 2020

While the current preset was made to pretty much a match the existing laravel/ui presets one-to-one, I feel like we could probably go a little bit further for people that want it, to get even closer to a real-world application, and offer some extra utilities out of the box.

Here are some of the things I think this "extra" option could possibly do:

  • Include some basic styling for the "app" layout"
  • Include a "change password" form for authenticated users
  • Include a few basic components/classes for things like form elements
  • Include additional tools commonly used in the stack, like Spruce, Alpine Test Utils and implement Tailwind CSS Spinner into the loading states

It may be a little more opinionated than the basic version, without being a full-blown boilerplate.

What do people think of this? Is this something we could consider or is it just out of the scope of this package?

@minthemiddle
Copy link

I feel that laravel/ui could be even more opinionated and should include things you consider "extra". So this project could be leading the way here.

@imliam imliam added the enhancement New feature or request label May 9, 2020
@lewislarsen
Copy link
Contributor

lewislarsen commented May 14, 2020

The suggestions you made doesn't seem too bad, if you're considering a change password form, why not include a change email form as well? This should cover the basics of account management, although I am concerned about adding too much to this additional extra preset option.

I take it the basic styling will be using TailwindUI much like the login/register forms are? Would be good as it would achieve consistency throughout the preset.

Having checked the license for TailwindUI, it seems it would be okay to use paid components within the preset if we needed to, however we can likely get away with using the free preview components since we only need a basic layout as an improved starting point. (TailwindUI Preview Components)

I do think that having a fleshed out account management "feature" of this option would proceed to be incredibly beneficial, it means that people can start working on their core code and less having to make sure that users can change their email, password and so forth.

On a whole, I believe it is a good idea and it should exist, but we need to be careful about not implementing too much bloat into this additional preset option for TALL.

@imliam
Copy link
Contributor Author

imliam commented May 19, 2020

I've made a start in #31 that, right now, just has an application layout shell. If people are okay with that as it is, we can merge it and add each additional thing separately so there's some discussion about what extra features should be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants