-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name collision with Seed files #39
Comments
We could namespace them, but that's not "standard" Laravel, and is hard to enforce in community-submitted hooks. |
Yea, I think it would be a good idea to namespace them, but Laravel seeder does not support that by default, so will need to overwrite some code in the seeder script. |
Laravel's seeder should handle that just fine. You just have to call the class explicitly with the namespace |
We cannot use Seed files using the same name of any of Voyager files, like
DataRowsTableSeeder
,PermissionsTableSeeder
, etc., because they are being autoloaded from composer.As result, when installing a Hook the system will use classes from the auloaded, missing the seeds located on the Hook folder.
This bug was hard to figure out, because install will run fine without any error message.
The text was updated successfully, but these errors were encountered: