Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A validation issue #4

Open
FadyAyad opened this issue Dec 7, 2014 · 0 comments
Open

A validation issue #4

FadyAyad opened this issue Dec 7, 2014 · 0 comments

Comments

@FadyAyad
Copy link

FadyAyad commented Dec 7, 2014

when you validate the hash you make sure that is unique, but what if the hash that the UrlHasher class creates is already in the database? You throw a ValidationException and returns back to the user without telling him what went wrong. What you should have done is making sure that the LittleService class gets a unique hash from the UrlHasher before trying to inject it in the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant