Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualified names with .type in the middle #8

Open
langston-barrett opened this issue Oct 22, 2022 · 2 comments
Open

Qualified names with .type in the middle #8

langston-barrett opened this issue Oct 22, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed semver/patch Requires a patch version bump (i.e., bugfix)

Comments

@langston-barrett
Copy link
Owner

The parser can't handle qualified names where .type is one of the "middle" names, e.g.,

.output bar.type.foo
@langston-barrett langston-barrett added bug Something isn't working help wanted Extra attention is needed labels Oct 22, 2022
@langston-barrett
Copy link
Owner Author

The test Qualified name with ".type" shows this error.

@langston-barrett
Copy link
Owner Author

langston-barrett commented Oct 24, 2022

This can be fixed by making qualified_name into a regex token (qualified_name: $ => /((_|\?|[A-Z]|[a-z])(([A-Z]|[a-z])|[0-9]|_|\?)*)(\.((_|\?|[A-Z]|[a-z])(([A-Z]|[a-z])|[0-9]|_|\?)*))*/) but that's horrible and also causes the test "Unary functor declaration" to fail...

It feels like there should be a solution involving word: or token.immediate.

@langston-barrett langston-barrett added the semver/patch Requires a patch version bump (i.e., bugfix) label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed semver/patch Requires a patch version bump (i.e., bugfix)
Projects
None yet
Development

No branches or pull requests

1 participant