Skip to content

Commit 0cc30cd

Browse files
committed
attempt different node14 installation in php 7.0 tests and fix doc lnx part 2
1 parent a58880f commit 0cc30cd

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/config.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ You may need to override our [default PHP config](https://github.com/lando/php/b
236236

237237
If you do this, you must use files that exist inside your application and express them relative to your project root as shown below:
238238

239-
Note that the default files may change based on how you set both `ssl` and `via`. Also note that the `vhosts` and `server` config will be either for `apache` or `nginx` depending on how you set `via`. We *highly recommend* you check out both the [apache](https://docs.lando.dev/plugins/apache/) and [nginx](https://docs.lando.dev/plugins/nginx/) if you plan to use a custom `vhosts` or `server` config.
239+
Note that the default files may change based on how you set both `ssl` and `via`. Also note that the `vhosts` and `server` config will be either for `apache` or `nginx` depending on how you set `via`. We *highly recommend* you check out both the [apache](https://docs.lando.dev/plugins/apache/index.html) and [nginx](https://docs.lando.dev/plugins/nginx/index.html) if you plan to use a custom `vhosts` or `server` config.
240240

241241
If you set `via: cli` then, as you might suspect, `vhosts` and/or `server` is not going to do anything.
242242

docs/development.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ At the very least you will need to have the following installed:
1313

1414
* [Lando 3.21.0+](https://docs.lando.dev/getting-started/installation.html) preferably installed [from source](https://docs.lando.dev/install/source.html).
1515
* [Git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)
16-
* [Node 18](https://nodejs.org/dist/latest-v18.x/)
16+
* [Node 20](https://nodejs.org/dist/latest-v20.x/)
1717

1818
## Installation
1919

examples/7.4/.lando.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ services:
1010
composer_version: 1-latest
1111
via: cli
1212
build_as_root:
13-
- curl -sL https://deb.nodesource.com/setup_14.x | bash -
14-
- apt-get update -y
15-
- apt-get install -y nodejs
13+
- curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
14+
- bash -c ". /root/.nvm/nvm.sh && nvm install 14.17.3 && nvm use 14.17.3 && nvm alias default 14.17.3"
1615
cliworker:
1716
type: php:7.4
1817
composer_version: false
@@ -46,6 +45,7 @@ tooling:
4645
service: defaults
4746
node:
4847
service: :host
48+
cmd: /root/.nvm/versions/node/v14.17.3/bin/node
4949
options:
5050
host:
5151
description: The service to use

examples/8.0/.lando.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ services:
99
type: php:8.0
1010
via: cli
1111
build_as_root:
12-
- curl -sL https://deb.nodesource.com/setup_14.x | bash -
13-
- apt-get update -y
14-
- apt-get install -y nodejs
12+
- curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
13+
- bash -c ". /root/.nvm/nvm.sh && nvm install 14.17.3 && nvm use 14.17.3 && nvm alias default 14.17.3"
1514
cliworker:
1615
type: php:8.0
1716
composer_version: false
@@ -45,6 +44,7 @@ tooling:
4544
service: defaults
4645
node:
4746
service: :host
47+
cmd: /root/.nvm/versions/node/v14.17.3/bin/node
4848
options:
4949
host:
5050
description: The service to use

0 commit comments

Comments
 (0)