Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix product issues #257

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Fix product issues #257

merged 13 commits into from
Oct 4, 2024
+164 −91

Conversation

dillonalaird
Copy link
Member

@dillonalaird dillonalaird commented Oct 4, 2024 •
edited
Loading

  • Fixes issue where code was returned with !pip install lines
  • Adds more clear error messages for image saving and video saving side cases
  • Makes VisionAgent less verbose in messages to the user
  • Use overlay_bounding_boxes for count now

camiloaz
camiloaz approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@camiloaz camiloaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment, but lgtm.

vision_agent/agent/vision_agent.py
Comment on lines -410 to -411
artifacts.load(self.local_artifacts_path)
artifacts.save()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is intended. but I'm not too familiar with the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing front end some issues. I did some local tests and I don't think removing it causes any issues

@dillonalaird dillonalaird merged commit 0eaf6ce into main Oct 4, 2024
8 checks passed
@dillonalaird dillonalaird deleted the fix-product-issues branch October 4, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camiloaz camiloaz camiloaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dillonalaird @camiloaz