Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues with VisionAgentCoder using Claude-3.5 #250

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

dillonalaird
Copy link
Member

@dillonalaird dillonalaird commented Sep 25, 2024

Several changes were added to this PR:

  • Added examples to the coder agent, this is to ensure it properly handles the function arguments (want it to take in a media path instead of a numpy array)
  • Moved instructions to last part of prompt, seems to improve performance to have instructions last
  • Extra instructions to not make dummy variables or functions

Copy link
Collaborator

@shankar-vision-eng shankar-vision-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at it ,wanted to double confirm before i approve. i see 3 changes

  • Move instructions below example (why ? )
  • More clear prompts not to use dummy functions , we used to have these in our original prompts when this problem was common - Good with this
  • A full fledged example in code prompt , correct ? It doesn't code well without this or any specific reason

Copy link
Collaborator

@shankar-vision-eng shankar-vision-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dillonalaird dillonalaird merged commit 95a9381 into main Sep 25, 2024
8 checks passed
@dillonalaird dillonalaird deleted the fix-vacoder-issues branch September 25, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants