Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add function_name in tool_calls payload if it's missing #243

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

yzld2002
Copy link
Member

countgd_counting and countgd_example_based_counting are using send_task_inference_request to call the model, which does not have function_name in the request payload. However, the UI needs this name to correctly show the tool calls trace.

This PR makes sure the function_name is in the tool_calls payload.

Local test:
image

@yzld2002 yzld2002 merged commit 93be51a into main Sep 23, 2024
8 checks passed
@yzld2002 yzld2002 deleted the zhichao-fix-countgd-function-name-missing branch September 23, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants