Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Transformer-XL shift method #185

Open
Bearnardd opened this issue May 16, 2023 · 1 comment
Open

Bug in Transformer-XL shift method #185

Bearnardd opened this issue May 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Bearnardd
Copy link

Hi!
In the original paper implementation they are using dims [1:] : x = x_padded[1:].view_as(x) their code but in your implementation you are using [:-1]: x = x_padded[:-1].view_as(x) your code which produces wrong matrix at the output.

@vpj vpj added the bug Something isn't working label Jun 30, 2023
@hacihasanzade
Copy link

from typing import Optional, List. is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants