-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiHeadAttention parameter setting #180
Labels
Comments
The get_positional_encoding method of position encoder generates an error when d_model is set to odd |
Our implementation assumes that heads * d_k = d_model. Need to change that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is the output linear layer parameter of the MultiHeadAttention class incorrectly set in mha.py file? in_features should be heads*d_k?
The text was updated successfully, but these errors were encountered: