Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The toml parser library needs to be replaced. #2382

Open
Tracked by #2377
ironAiken2 opened this issue Apr 29, 2024 · 0 comments · May be fixed by #2383
Open
Tracked by #2377

bug: The toml parser library needs to be replaced. #2382

ironAiken2 opened this issue Apr 29, 2024 · 0 comments · May be fixed by #2383
Assignees

Comments

@ironAiken2
Copy link
Contributor

ironAiken2 commented Apr 29, 2024

What Operating System(s) are you seeing this problem on?

macOS (Apple Silicon)

Backend.AI version

24.09.0dev1

Describe the bug

Summary page app download link doesn't work. I've figured out that there's a problem with the current TOML parsing process. Additionally, A syntax error occurs if the TOML file contains an empty string during preprocessing. ref

Currently, webui is using the 'markty-toml' parser. This library currently has some issues with comment handling, which are not yet resolved. github ref

In addition to this, I've tested it myself and found that it doesn't load the value correctly
Because of this, I think a replacement for the toml parser library is needed.

const example = `
          [general]
          commentExample = "This is a comment."     # This is a comment.
          stringExample = "Hello, World!"           # Hello, World!
          booleanExample = true                     # true
          numberExample = 123                       # 123
          floatExample = 123.456                    # 123.456
        `;
image

To Reproduce

No response

Expected Behavior

No response

Anything else?

No response

@ironAiken2 ironAiken2 self-assigned this Apr 29, 2024
@yomybaby yomybaby changed the title bug: summary page download link doesn't work bug: summary page download link doesn't work if appDownloadUrl config has a inline comment Apr 30, 2024
@ironAiken2 ironAiken2 changed the title bug: summary page download link doesn't work if appDownloadUrl config has a inline comment bug: The toml parser library needs to be replaced. May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant