remote/client: do not print deleted resource's class on monitor #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On delete, resource is an empty dictionary:
ERROR labgrid.remote.: ClientSession.onUserError(): "While firing <bound method ClientSession.on_resource_changed of <labgrid.remote.client.ClientSession object at 0x7fcf1cbdff90>> subscribed under 8031289985454517."
Traceback (most recent call last):
File "/usr/ptx-venvs/labgrid/lib/python3.11/site-packages/txaio/aio.py", line 487, in done
res = f.result()
^^^^^^^^^^
File "/usr/ptx-venvs/labgrid/lib/python3.11/site-packages/labgrid/remote/client.py", line 126, in on_resource_changed
print(f"Resource {exporter}/{group_name}/{resource['cls']}/{resource_name} deleted")
~~~~~~~~^^^^^^^
KeyError: 'cls'
This can be reproduced easily by restarting an exporter while running
`labgrid-client monitor`.
We could publish the class, but that would only work for new exporters.
For now, simply replace the class name with "???".
Fixes: f9d4ccd ("remote/client: print full resource identifier on monitor")
Signed-off-by: Bastian Krause <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
========================================
- Coverage 62.9% 62.9% -0.1%
========================================
Files 161 161
Lines 11861 11861
========================================
- Hits 7470 7469 -1
- Misses 4391 4392 +1
☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On delete, resource is an empty dictionary:
This can be reproduced easily by restarting an exporter while running
labgrid-client monitor.We could publish the class, but that would only work for new exporters. For now, simply replace the class name with "???".
Checklist
Fixes #1178