You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Other drivers use self.target.env.config.get_tool(...) to retrieve a tool path from the configuration.
The SSHDriver uses raw "ssh", "scp", "rsync" and "sshfs" calls.
It would be useful to respect those keys in the configuration tools map. Then OpenSSH binaries can be provided in the configuration that may have been hermetically built by an external system. This would require to add a lookup for those keys in the SSHDriver and update the subcommands to use the result.
# FIXME make sure we always have an environment or configifself.target.env:
self.tool=self.target.env.config.get_tool('dfu-util')
else:
self.tool='dfu-util'
The tests for SSHDriver do not always provide a config so would need the same pattern. Should we change the tests to always provide a configuration? Are there legitimate situations that the SSHDriver is used without a configuration?
Other drivers use
self.target.env.config.get_tool(...)
to retrieve a tool path from the configuration.The
SSHDriver
uses raw"ssh"
,"scp"
,"rsync"
and"sshfs"
calls.It would be useful to respect those keys in the configuration
tools
map. Then OpenSSH binaries can be provided in the configuration that may have been hermetically built by an external system. This would require to add a lookup for those keys in theSSHDriver
and update the subcommands to use the result.Some tools have the following pattern:
The tests for
SSHDriver
do not always provide a config so would need the same pattern. Should we change the tests to always provide a configuration? Are there legitimate situations that theSSHDriver
is used without a configuration?The keys would be added to TOOL KEYS.
The text was updated successfully, but these errors were encountered: