Merge pull request #1216 from Bastian-Krause/bst/coordinator-drop-tic…

…ket-auth remote/authenticator: drop obsolete ticket authenticator
labgrid-project · Sep 6, 2023 · 7d22e76 · 7d22e76
2 parents 8e1e683 + 94400cc
commit 7d22e76
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 27 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -30,6 +30,9 @@ Bug fixes in 23.1
 
 Breaking changes in 23.1
 ~~~~~~~~~~~~~~~~~~~~~~~~~
+- Support for the legacy ticket authentication was dropped: If the coordinator
+  logs ModuleNotFoundError on startup, switch the crossbar config to anonymous
+  authentication (see ``.crossbar/config-anonymous.yaml`` for an example).
 - The Debian package (``debian/``) no longer contains crossbar. Use the
   `coordinator container <https://hub.docker.com/r/labgrid/coordinator>`_ or
   install it into a separate local venv as desribed in the

diff --git a/labgrid/remote/authenticator.py b/labgrid/remote/authenticator.py
diff --git a/labgrid/remote/coordinator.py b/labgrid/remote/coordinator.py
@@ -133,14 +133,11 @@ async def onConnect(self):
         enable_tcp_nodelay(self)
         self.join(
             self.config.realm,
-            authmethods=["anonymous", "ticket"],
+            authmethods=["anonymous"],
             authid="coordinator",
             authextra={"authid": "coordinator"},
         )
 
-    def onChallenge(self, challenge):
-        return "dummy-ticket"
-
     @locked
     async def onJoin(self, details):
         await self.subscribe(self.on_session_join, 'wamp.session.on_join')

diff --git a/pyproject.toml b/pyproject.toml
@@ -161,9 +161,6 @@ testpaths = [
 ]
 addopts = "-p no:labgrid"
 
-[tool.pylint.MASTER]
-ignore-paths = ["labgrid/remote/authenticator.py"]
-
 [tool.pylint.imports]
 ignored-modules = ["gi"]