Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the logic for add/delete flows #58

Open
viniarck opened this issue Apr 5, 2018 · 0 comments
Open

Review the logic for add/delete flows #58

viniarck opened this issue Apr 5, 2018 · 0 comments

Comments

@viniarck
Copy link
Contributor

viniarck commented Apr 5, 2018

Currently, if the dpid is None, it's installing flows in all switches: https://github.com/kytos/flow_manager/blob/master/main.py#L52-L59

The same logic is also being applied for the delete method. So, this issue is to review this logic and assess a better one. Maybe, a new method which could iterate over all switches, but stop relying on this 'None' to consider the whole list.

@viniarck viniarck changed the title Review the logic for add flows Review the logic for add/delete flows Apr 5, 2018
@beraldoleal beraldoleal added this to the 2018.1b2 milestone Apr 6, 2018
@macartur macartur modified the milestones: 2018.1b2, 2018.1b3 Apr 19, 2018
@macartur macartur modified the milestones: 2018.1b3, 2018.2b1 Jun 13, 2018
@hdiogenes hdiogenes removed this from the 2018.2b1 milestone Jan 22, 2020
ajoaoff pushed a commit to ajoaoff/flow_manager that referenced this issue Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants