Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitSigns and Neovim #16

Open
Looooopy opened this issue Mar 19, 2022 · 3 comments
Open

GitSigns and Neovim #16

Looooopy opened this issue Mar 19, 2022 · 3 comments

Comments

@Looooopy
Copy link

Looooopy commented Mar 19, 2022

I was trying to use your theme with neovim and gitsigns plugin but its missing some highlights

When I added these it was working fine

hi GitSignsAdd guifg=#5FFF87
hi GitSignsChange guifg=#FFFF87
hi GitSignsDelete guifg=#FF875F

Can you add them into your theme?

Before Adding those highlights
I think its using these highlights then it do not find hi for GitSignsXXX

call s:hi('DiffAdd',      { 'fg': s:black, 'bg': s:green })
call s:hi('DiffChange',   { 'fg': s:black, 'bg': s:yellow })
call s:hi('DiffDelete',   { 'fg': s:black, 'bg': s:salmon })

image

After
image

@kyoz
Copy link
Owner

kyoz commented Mar 19, 2022

Hello @Looooopy , thank you so much, indeed cause i haven't support GitSigns yet, i'll review GitSigns code base all fully implement it soon, but sadly it must be in next month. Currently, i'm building my new working desk and i've sold my laptop :((.

@Looooopy
Copy link
Author

NP!

I have added a temporary fix that set that after in my colorscheme is applied so no rush but it is always nice to remove unnecessary code :)

@kyoz
Copy link
Owner

kyoz commented Mar 31, 2022

Hello @Looooopy, i've just update the plugin, please give it a try.

For now it just support for common usecases, by looking at the plugin, i see there is some other hl like GitSignsAddNr ... But i don't use this plugin so it'll be great if you could help me to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants