Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show appropriate status message via self monitor if a target is close to scrape limit #1037

Open
rakesh-garimella opened this issue May 6, 2024 · 3 comments
Labels
area/manager Manager or module changes area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.

Comments

@rakesh-garimella
Copy link
Contributor

rakesh-garimella commented May 6, 2024

Description
As part of #976 the metric-agent should expose under a dedicated port the diagnostic metrics relevant for scraping metric targets via the prometheusreceiver. The new port should be protected by a networkpolicy so that user cannot reach it. For now the plain exposure is enough in order to enable operational diagnostic.

Criterias

  • There is a new port under which the diagnostic metrics of the prometheusreceiver are accessible at /metrics
  • No other metrics are exposed there
  • The user cannot access the port

Implementation details

Example configuration for metrics agent

pipelines:
            metrics/istio:
                ...
                exporters:
                    - otlp
                    - prometheus
            metrics/prometheus:
                ...
                exporters:
                    - otlp
                    - prometheus
            metrics/runtime:
                ...
                exporters:
                    - otlp
                    - prometheus
 exporters:
        prometheus:
            endpoint: "127.0.0.1:1888" # Prometheus  exporter config
        ...

Probably we should not expose just all metrics but also filter out business metrics. So instead we should use a new dedicated pipeline having the same receivers as input, but doing a specialized filtering and exporting

@rakesh-garimella rakesh-garimella changed the title If a target is close to scrape limit show appropriate status message via self monitor Show appropriate status message via self monitor if a target is close to scrape limit May 6, 2024
@rakesh-garimella rakesh-garimella added area/metrics MetricPipeline area/manager Manager or module changes kind/feature Categorizes issue or PR as related to a new feature. labels May 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2024
Copy link

This issue has been automatically closed due to the lack of recent activity.
/lifecycle rotten

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
@kyma-bot kyma-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 13, 2024
@a-thaler a-thaler reopened this Jul 15, 2024
@a-thaler a-thaler removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 15, 2024
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2024
@a-thaler a-thaler removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants