Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleCatalog] Deprecate .spec.channel in ModuleTemplate #1839

Open
4 tasks
c-pius opened this issue Sep 6, 2024 · 1 comment
Open
4 tasks

[ModuleCatalog] Deprecate .spec.channel in ModuleTemplate #1839

c-pius opened this issue Sep 6, 2024 · 1 comment
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Sep 6, 2024

Description

In #1681 it has been decided that ModuleTemplates are tied to versions and not to channels. In #1591 we already made .spec.channel optional. We can also mark this attribute as deprecated and remove it in the future.

Reasons

Clean API from unused fields.

Acceptance Criteria

Feature Testing

No response

Testing approach

No response

Attachments

No response

@c-pius c-pius added kind/feature Categorizes issue or PR as related to a new feature. API Denotes that an issue is tied to the potential change of the API labels Sep 6, 2024
@c-pius
Copy link
Contributor Author

c-pius commented Oct 1, 2024

Proposal to be discussed: once deprecated, we can already update modulectl to issue an error when trying to provide a channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant