Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop labels when the module is unmanaged #1823

Open
1 of 4 tasks
janmedrek opened this issue Sep 3, 2024 · 0 comments · May be fixed by #1913
Open
1 of 4 tasks

Drop labels when the module is unmanaged #1823

janmedrek opened this issue Sep 3, 2024 · 0 comments · May be fixed by #1913
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@janmedrek
Copy link
Contributor

janmedrek commented Sep 3, 2024

Description

Right now, when the user unmanages the module KLM no longer cares about the module deployment in the SKR. However, the labels managed-by and watched-by are still kept on the resources that were present in the module manifest.

Reasons

We want to keep transparency on what is going on with the resources when a module is unmanaged.

Acceptance Criteria

  • Drop the watched-by label from resources when a module is unmanaged
  • Drop the managed-by label from resources when a module is unmanaged
  • Add a dedicated finalizer to mark resources for the label to be removed (label deletion in progress)
  • Introduce a new requeue reason for this one (use existing metrics)

Feature Testing

No response

Testing approach

No response

Attachments

No response

@janmedrek janmedrek added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 3, 2024
@nesmabadr nesmabadr self-assigned this Oct 1, 2024
@nesmabadr nesmabadr removed their assignment Oct 4, 2024
@lindnerby lindnerby self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants