Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Threat Modeling] End-to-end testing of Envoy filter creation #1002

Open
7 tasks
Tracked by #773
TorstenD-SAP opened this issue Sep 2, 2024 · 0 comments
Open
7 tasks
Tracked by #773

[Threat Modeling] End-to-end testing of Envoy filter creation #1002

TorstenD-SAP opened this issue Sep 2, 2024 · 0 comments
Labels
area/documentation Issues or PRs related to documentation area/service-mesh Issues or PRs related to service-mesh kind/feature Categorizes issue or PR as related to a new feature.

Comments

@TorstenD-SAP
Copy link

TorstenD-SAP commented Sep 2, 2024

Description

An end-to-end test has to be implemented to test, if the Envoy filter is created in the right Namespace. User Namespace RateLimit CRs have to lead to Envoy filters in this Namespace, RateLimit CRs in the istio-system Namespace have to lead to Envoy filters applied to the ingress gateway.

Reasons

The only separation between cluster-wide applied rate limits applied on the IngressGateway and namespaced rate limits is the place, where the RateLimit CRs is stored. This is a feature of the operator. We have to ensure this behavior cannot be broken by accident.

DoD:

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • If the default configuration of Istio Operator has been changed, you performed a manual upgrade test to verify that the change can be rolled out correctly.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments

part of: #773

@TorstenD-SAP TorstenD-SAP added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2024
@strekm strekm added area/service-mesh Issues or PRs related to service-mesh area/documentation Issues or PRs related to documentation labels Sep 5, 2024
@strekm strekm mentioned this issue Sep 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/service-mesh Issues or PRs related to service-mesh kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants