Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of X-Forwarded-Host header #1159

Open
6 tasks
Tracked by #322
barchw opened this issue Jul 11, 2024 · 0 comments
Open
6 tasks
Tracked by #322

State of X-Forwarded-Host header #1159

barchw opened this issue Jul 11, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@barchw
Copy link
Collaborator

barchw commented Jul 11, 2024

Description
In the current v1beta1 version, the singular Host field is used to fill in the X-Forwarded-Host http header. APIRule v2alpha1 will introduce support for matching on multiple Hosts. This influences logic of how to set this value, as it is not possible to be sure that the client request always requested the same Host.

As result of the above, there is a need to evaluate the support for this header. If possible, the aim should be to dynamically fill in the value, for example by utilisation of (if such feature is present) Envoy/Istio feature.

If it will not be possible to ensure that this value is dynamically filled in, the next step should be evaluation of the support for this header.

Reasons

  • Introduction of APIRule v2alpha1

DoD:

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments

@barchw barchw added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 11, 2024
@triffer triffer mentioned this issue Jul 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant