Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code structure #16

Open
d-jo opened this issue Dec 16, 2018 · 1 comment
Open

Refactoring code structure #16

d-jo opened this issue Dec 16, 2018 · 1 comment
Assignees

Comments

@d-jo
Copy link
Collaborator

d-jo commented Dec 16, 2018

Currently the src/lib.rs file is empty, and that file should contain the library logic. The types can stay separated, but the querying should be moved to a src/lib.rs

This change is pretty important for tests, as the methods will be able to be accessed easily.

@d-jo
Copy link
Collaborator Author

d-jo commented Dec 16, 2018

On second thought, the structs could be merged into a single file as well, maybe src/types.rs? The src directory would contain lib.rs types.rs

I've prepared a branch that does what I am proposing, it still contains a main file but that will change after integration tests are started.

Once #15 is accepted I will submit a PR.

@d-jo d-jo self-assigned this Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant