Address review comments

Author: royi-luo

src/include/storage/free_space_manager.h

@@ -1,3 +1,9 @@
+/**
+ * We would like to thank Mingkun Ni and Mayank Jasoria for doing the initial research and
+ * prototyping for the FreeSpaceManager in their CS 848 course project:
+ * https://github.com/ericpolo/kuzu_cs848
+ */
+
 #pragma once
 
 #include <optional>

src/include/storage/page_manager.h

@@ -4,7 +4,7 @@
 
 #include "common/types/types.h"
 #include "storage/free_space_manager.h"
-#include "storage/page_chunk_entry.h"
+#include "storage/page_range.h"
 
 namespace kuzu {
 namespace transaction {

src/include/storage/page_chunk_entry.h renamed to src/include/storage/page_range.h

@@ -2,16 +2,16 @@
 
 #include "common/types/types.h"
 #include "storage/compression/compression.h"
-#include "storage/page_chunk_entry.h"
+#include "storage/page_range.h"
 
 namespace kuzu::storage {
 struct ColumnChunkMetadata {
-    PageRange pageChunk;
+    PageRange pageRange;
     uint64_t numValues;
     CompressionMetadata compMeta;
 
-    common::page_idx_t getStartPageIdx() const { return pageChunk.startPageIdx; }
-    common::page_idx_t getNumPages() const { return pageChunk.numPages; }
+    common::page_idx_t getStartPageIdx() const { return pageRange.startPageIdx; }
+    common::page_idx_t getNumPages() const { return pageRange.numPages; }
 
     // Returns the number of pages used to store data
     // In the case of ALP compression, this does not include the number of pages used to store
@@ -23,11 +23,11 @@ struct ColumnChunkMetadata {
 
     // TODO(Guodong): Delete copy constructor.
     ColumnChunkMetadata()
-        : pageChunk(common::INVALID_PAGE_IDX, 0), numValues{0},
+        : pageRange(common::INVALID_PAGE_IDX, 0), numValues{0},
           compMeta(StorageValue(), StorageValue(), CompressionType::CONSTANT) {}
     ColumnChunkMetadata(common::page_idx_t pageIdx, common::page_idx_t numPages, uint64_t numValues,
         const CompressionMetadata& compMeta)
-        : pageChunk(pageIdx, numPages), numValues(numValues), compMeta(compMeta) {}
+        : pageRange(pageIdx, numPages), numValues(numValues), compMeta(compMeta) {}
 };
 
 class GetCompressionMetadata {

src/include/storage/store/column_chunk_metadata.h

@@ -3,7 +3,7 @@
 #include "common/serializer/deserializer.h"
 #include "common/serializer/serializer.h"
 #include "common/utils.h"
-#include "storage/page_chunk_entry.h"
+#include "storage/page_range.h"
 
 namespace kuzu::storage {
 static FreeSpaceManager::sorted_free_list_t& getFreeList(

src/storage/free_space_manager.cpp

@@ -352,7 +352,7 @@ offset_t Column::appendValues(ColumnChunkData& persistentChunk, ChunkState& stat
     const auto numNewPages =
         writeValues(state, metadata.numValues, data, nullChunkData, 0 /*dataOffset*/, numValues);
     KU_ASSERT(numNewPages == 0);
-    metadata.pageChunk.numPages += numNewPages;
+    metadata.pageRange.numPages += numNewPages;
 
     auto [minWritten, maxWritten] = getMinMaxStorageValue(data, 0 /*offset*/, numValues,
         dataType.getPhysicalType(), nullChunkData);

src/storage/store/column.cpp

@@ -35,7 +35,7 @@ namespace kuzu {
 namespace storage {
 
 void ChunkState::reclaimAllocatedPages(FileHandle& dataFH) const {
-    const auto& entry = metadata.pageChunk;
+    const auto& entry = metadata.pageRange;
     if (entry.startPageIdx != INVALID_PAGE_IDX) {
         dataFH.getPageManager()->freePageRange(entry);
     }

src/storage/store/column_chunk_data.cpp

@@ -73,16 +73,16 @@ ColumnChunkMetadata booleanGetMetadata(std::span<const uint8_t> buffer, uint64_t
 }
 
 void ColumnChunkMetadata::serialize(common::Serializer& serializer) const {
-    serializer.write(pageChunk.startPageIdx);
-    serializer.write(pageChunk.numPages);
+    serializer.write(pageRange.startPageIdx);
+    serializer.write(pageRange.numPages);
     serializer.write(numValues);
     compMeta.serialize(serializer);
 }
 
 ColumnChunkMetadata ColumnChunkMetadata::deserialize(common::Deserializer& deserializer) {
     ColumnChunkMetadata ret;
-    deserializer.deserializeValue(ret.pageChunk.startPageIdx);
-    deserializer.deserializeValue(ret.pageChunk.numPages);
+    deserializer.deserializeValue(ret.pageRange.startPageIdx);
+    deserializer.deserializeValue(ret.pageRange.numPages);
     deserializer.deserializeValue(ret.numValues);
     ret.compMeta = decltype(ret.compMeta)::deserialize(deserializer);