Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on referring react.PropTypes on 0.0.6 package #122

Open
gunyarakun opened this issue Nov 5, 2017 · 2 comments
Open

Error on referring react.PropTypes on 0.0.6 package #122

gunyarakun opened this issue Nov 5, 2017 · 2 comments

Comments

@gunyarakun
Copy link

With [email protected], Uncaught TypeError: Cannot read property 'string' of undefined occurs because lib/react/link.js in the released 0.0.6 package from npm includes these lines which uses react.PropTypes.

Link.propTypes = {
  to: _react.PropTypes.string,
  href: _react.PropTypes.string,
  external: _react.PropTypes.bool,
  target: _react.PropTypes.string,
  className: _react.PropTypes.string,
  onClick: _react.PropTypes.func
};

I think separating the package prop-types from react at React v15.5 would cause this issue.
https://reactjs.org/docs/typechecking-with-proptypes.html

Rebuilding redux-tower from the latest source codes resolves the problem in my environment.

ygkn added a commit to ygkn/DJ-YAGICHAN-SYSTEM that referenced this issue Nov 9, 2017
Because: lates release version dose not support React v15.5
ref: kuy/redux-tower#122
@kuy
Copy link
Owner

kuy commented Nov 10, 2017

@gunyarakun Thanks for giving comment. I'll rebuild and release within few days.

@goncy
Copy link

goncy commented Jun 30, 2018

This was solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants