Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kumaclt export prints Mesh resource twice #13109

Closed
Automaat opened this issue Mar 14, 2025 · 0 comments · Fixed by #13111
Closed

Kumaclt export prints Mesh resource twice #13109

Automaat opened this issue Mar 14, 2025 · 0 comments · Fixed by #13111
Assignees
@lukidzi
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@Automaat
Copy link
Contributor

Automaat commented Mar 14, 2025 •
edited
Loading

Kuma Version

2.9.x

Describe the bug

When we have Mesh with MeshService exclusive enabled, then if we run kumactl export we get Mesh resource twice and one of them is empty.

To Reproduce

Enable MeshService exclusive mode and run kumactl export and run: kumactl export --format universal

Expected behaviour

We should return single Mesh resource
@Automaat Automaat added kind/bug A bug triage/pending This issue will be looked at on the next triage meeting labels Mar 14, 2025
@lukidzi lukidzi self-assigned this Mar 14, 2025
@lukidzi lukidzi mentioned this issue Mar 14, 2025
Merged
@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 17, 2025
lukidzi added a commit that referenced this issue Mar 20, 2025
@lukidzi
fix(kumactl): don't export mesh object twice (#13111)
5c44b94 
## Motivation

Mesh needs to be defined before creating other resources. That's why we
need it to be first entry in the exported object:
#11511

## Implementation information

I've changed logic to store mesh objects in a different list and later
add it first to the exported file.

## Supporting documentation

Fix #13109

> run full matrix to check if it doesn't impact federation test

Signed-off-by: Lukasz Dziedziak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukidzi lukidzi

Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kumactl): don't export mesh object twice lukidzi/kuma
2 participants
@Automaat @lukidzi