Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify "kubebuilder:validation:Enum" #12911

Open
slonka opened this issue Feb 24, 2025 · 0 comments
Open

Unify "kubebuilder:validation:Enum" #12911

slonka opened this issue Feb 24, 2025 · 0 comments
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@slonka
Copy link
Contributor

slonka commented Feb 24, 2025

Description

Coming from #12895 (comment)

We have places where we use this annotation to validate enums and places where we don't. We should unify that.

Be careful about a case where there was no validation and a global is on k8s, a user when upgrading global first can start receiving errors policies that sync from zone -> global.
@slonka slonka added kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting labels Feb 24, 2025
@slonka slonka mentioned this issue Feb 24, 2025
Merged
@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slonka @bartsmykla