Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspect API toResourceRules to include envoy cluster name #11293

Closed
lobkovilya opened this issue Sep 3, 2024 · 3 comments
Closed

Inspect API toResourceRules to include envoy cluster name #11293

lobkovilya opened this issue Sep 3, 2024 · 3 comments
Assignees
@lobkovilya
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.11.x

Comments

@lobkovilya
Copy link
Contributor

Description

Kuma GUI needs to match envoy clusters with MS, MES and MZMS. The easiest way to do that is to return clusterName in the Inspect API. This way don't have to deal with cluster name parsing on the GUI.

Depends on the #11292, because at this moment DestinationName() returns different results on Zone and on Global.
@lobkovilya lobkovilya added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Sep 3, 2024
@lobkovilya lobkovilya mentioned this issue Sep 3, 2024
Closed
@johncowen johncowen mentioned this issue Sep 9, 2024
Closed
@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 9, 2024
@michaelbeaumont michaelbeaumont added this to the 2.9.x milestone Sep 9, 2024
@lobkovilya
Copy link
Contributor Author

lobkovilya commented Sep 12, 2024 •
edited
Loading

I pushed the expected change in OpenAPI spec to my branch https://github.com/kumahq/kuma/compare/master...lobkovilya:kuma:stat-prefix-spec-change?expand=1

@lobkovilya lobkovilya removed this from the 2.9.x milestone Sep 13, 2024
@lahabana
Copy link
Contributor

One the UI we've made the choice of splitting this to use in matching of policies. We may need to rework this in the future but we shouldn't need this in 2.9.x for now

@lahabana lahabana added this to the 2.10.x milestone Sep 13, 2024
@lahabana lahabana modified the milestones: 2.10.x, 2.11.x Feb 24, 2025
@lahabana lahabana mentioned this issue Mar 17, 2025
Closed
@lahabana
Copy link
Contributor

We're actually making EnvoyClusterName be resourceIdentifiers which would make this unecessary.
This work is happening in #12863

@lahabana lahabana closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lobkovilya lobkovilya

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.11.x
Development

No branches or pull requests
3 participants
@lahabana @michaelbeaumont @lobkovilya