Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the RV semantics in Upstream Kubernetes #39

Open
nilekhc opened this issue Jul 11, 2024 · 2 comments
Open

Changing the RV semantics in Upstream Kubernetes #39

nilekhc opened this issue Jul 11, 2024 · 2 comments

Comments

@nilekhc
Copy link

nilekhc commented Jul 11, 2024

We are codifying the schema of ResourceVersion in upstream Kubernetes with KEP.

tl;dr
With this change, we are parsing ResourceVersion to an int, thus explicitly defining RV as an integer rather than an opaque string as it is today. Does this affect the project in any way?

@divanodestiny
Copy link
Collaborator

@nilekhc sorry for late response. i have check the KEP.

Using Garbage Collection Cache means using RV as an integer to validate the freshness of the cache. Approval from SigArch is required on this RV semantics.
ref: beta

If I understand your idea right, you parsing ResourceVersion to an int just to validate the freshness of the cache. KubeBrain implement ResourceVersion as uint64. it could be a very large num. I advice that you should parse the string into uint64 or int64. It's what we do in pv controller now.

Though we implement RV as uint64 now, i am opposed to treat RV as integer in fact. it limit the extension of storage. In my opinion, a comparable vector is better than integer, but it's not accepted by community.

@pacoxu
Copy link

pacoxu commented Dec 19, 2024

In Kubernetes Contributor SUmmit NA 2024, there is a talk about RV https://youtu.be/lMAR9Z5RlN0?list=PL69nYSiGNLP3n4uLnCymwGVtaOIA7MfuP&t=1020. This is just a discussion or proposal, and not something already WIP.

  • 82051321511322:<index of batch>
  • (82051321511322<<64) + <index of batch>
  • revision=82051321511322,index=0,total=24,version=alpha1

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants