Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove custom reporters from functional tests #1139

Merged
merged 1 commit into from
Jan 24, 2025
Merged

chore: Remove custom reporters from functional tests #1139

merged 1 commit into from
Jan 24, 2025

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
The custom reporters are no longer used in ginkgo v2.

Which issue(s) this PR fixes:
Fixes #506
Jira: https://issues.redhat.com/browse/CNV-47117

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 20, 2024
@akrejcir
Copy link
Collaborator Author

Let's wait for QE review.

/hold

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 20, 2024
@akrejcir
chore: Remove custom reporters from functional tests
0c2b3d7 
The custom reporters are no longer used in ginkgo v2.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@akrejcir
Copy link
Collaborator Author

@geetikakay , can you please take a look if it is ok to remove these reporters, or if we should use them properly?

The current code ignores them, and they were not used since updating ginkgo to v2.
The change was merged 2 years ago: #471

@geetikakay
Copy link
Contributor

@geetikakay , can you please take a look if it is ok to remove these reporters, or if we should use them properly?

The current code ignores them, and they were not used since updating ginkgo to v2. The change was merged 2 years ago: #471

Thanks @akrejcir for the patch. I think this is dead code. I see issues in the Polarion reports for some of the test IDs & there are no reports for higher versions. I have raised the issue and am trying to find answers.

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@akrejcir
Copy link
Collaborator Author

akrejcir commented Jan 24, 2025 •
edited
Loading

@geetikakay , can you please take a look if it is ok to remove these reporters, or if we should use them properly?
The current code ignores them, and they were not used since updating ginkgo to v2. The change was merged 2 years ago: #471

Thanks @akrejcir for the patch. I think this is dead code. I see issues in the Polarion reports for some of the test IDs & there are no reports for higher versions. I have raised the issue and am trying to find answers.

I see. Can we remove the reporters for now, and then add them later if someone will need them?

@geetikakay
Copy link
Contributor

/lgtm

@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @lyarwood

0xFelix
0xFelix reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@akrejcir
Copy link
Collaborator Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@kubevirt-bot kubevirt-bot merged commit eaa6646 into kubevirt:main Jan 24, 2025
12 checks passed
@akrejcir akrejcir deleted the remove-reporters branch January 24, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@jcanocan jcanocan Awaiting requested review from jcanocan

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@geetikakay geetikakay

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ginkgo custom reporters are deprecated and should be removed from functest
5 participants
@akrejcir @geetikakay @jcanocan @kubevirt-bot @0xFelix