Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for remains of DV garbage collection and remove them #566

Closed
0xFelix opened this issue Dec 5, 2024 · 3 comments
Closed

Check for remains of DV garbage collection and remove them #566

0xFelix opened this issue Dec 5, 2024 · 3 comments
Assignees
Labels

Comments

@0xFelix
Copy link
Member

0xFelix commented Dec 5, 2024

What happened:

CDI deprecated the DV garbage collection, which was disabled by default for some time now. kubevirt-tekton-tasks should be checked for remains of support for this feature. They can be removed safely now.

See kubevirt/containerized-data-importer#3552

What you expected to happen:
A clear and concise description of what you expected to happen.

How to reproduce it (as minimally and precisely as possible):
Steps to reproduce the behavior.

Additional context:
Add any other context about the problem here.

Environment:

  • KubeVirt version (use virtctl version): N/A
  • Kubernetes version (use kubectl version): N/A
  • VM or VMI specifications: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Install tools: N/A
  • Others: N/A
@0xFelix
Copy link
Member Author

0xFelix commented Dec 5, 2024

/assign @ksimon1

@ksimon1
Copy link
Member

ksimon1 commented Jan 6, 2025

@0xFelix after checking the code, I don't think we have to do any changes to our code, since the code can be used even without DV GC.

@0xFelix
Copy link
Member Author

0xFelix commented Jan 7, 2025

If there are no workarounds or similar specific to the garbage collection left you can close this issue.

@ksimon1 ksimon1 closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants