Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: give users control over controller verbosity #2042

Open
1 task done
MikeSpreitzer opened this issue Apr 10, 2024 · 4 comments
Open
1 task done

feature: give users control over controller verbosity #2042

MikeSpreitzer opened this issue Apr 10, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high Highest priority. Must be actively worked on as someone's top priority right now. upcoming-release
Milestone

Comments

@MikeSpreitzer
Copy link
Contributor

Feature Description

The controller programs have command line flags for controlling their logging verbosity, but users do not currently have any control over that. Users should be able to control the logging verbosity of the controllers.

Proposed Solution

There are multiple layers to content with here, and different kinds of layers.

The easy case is Helm charts. They are parameterized and the parameters have default values.

A harder case is KubeFlex PostCreateHooks. In KubeFlex release 0.5.0 and later these can be parameterized, but they have no concept of default values.

There is also the ginkgo-based test.

There are also GitHub Actions workflows.

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

@MikeSpreitzer MikeSpreitzer added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 10, 2024
@MikeSpreitzer MikeSpreitzer added this to the 15-April-2024 milestone Apr 10, 2024
@ezrasilvera ezrasilvera added priority/high Highest priority. Must be actively worked on as someone's top priority right now. upcoming-release labels Apr 11, 2024
@MikeSpreitzer
Copy link
Contributor Author

PR #2041 addressed the kubestellar-controller-manager HelmChart and the bash script for running test/e2e/multi-cluster-deployment.

@ezrasilvera
Copy link
Contributor

@MikeSpreitzer Do you considered this as completed due to #2041 ? Maybe we should have different issues for unrelated (in terms of code) items (e.g., ginkgo) ?

@ezrasilvera
Copy link
Contributor

Also can you please elaborate which aspect of the multiple items you consider as high priority ?

@MikeSpreitzer
Copy link
Contributor Author

This is not done.
There is still more plumbing to be done.

Some of it involves unanswered design questions, see kubestellar/ocm-status-addon#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high Highest priority. Must be actively worked on as someone's top priority right now. upcoming-release
Projects
Status: In Progress
Development

No branches or pull requests

2 participants