Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ArgoCD source plugin after dog-fooding #1240

Open
pkosiec opened this issue Sep 8, 2023 · 1 comment
Open

Improve ArgoCD source plugin after dog-fooding #1240

pkosiec opened this issue Sep 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@pkosiec
Copy link
Member

pkosiec commented Sep 8, 2023

Description

Based on our dog fooding figure out the scope of ArgoCD plugin improvements. Confirm the scope inside the team.

Ideas

  • Add ArgoCD executor which is a ArgoCD CLI wrapped, which makes able to e.g. force resync the app

  • support commands like:
    - logs
    - describe app Already there
    - force re-sync
    - other:
    - GitHub diff link URL
    - restart pods kubectl command
    - Argo UI URL (?) Already there

  • validate request body in a generic way (in incoming webhook handler based on JSON schema)

  • useful filters to ignore spammy/not relevant events
    Notes:
    - https://argoproj.github.io/argo-events/sensors/filters/intro/
    - https://github.com/argoproj/argo-events/tree/master/examples/sensors

  • work on the message format to make it more user-friendly

    • if possible in the notification, include :
      • what version was is being deployed (v1.2.0 -> v1.2.1)
      • commit Author
      • GitHub diff link, e.g. main...b954115
  • fix Typo in Application botkube-cloud-backend has ben successfully synced

Blocked by #1239

@pkosiec pkosiec changed the title Polish ArgoCD plugin based on dog-fooding [3 MD] Improve ArgoCD source plugin after dog-fooding Sep 8, 2023
@pkosiec pkosiec added the enhancement New feature or request label Sep 8, 2023
@pkosiec pkosiec added this to the v1.5.0 milestone Sep 8, 2023
@pkosiec pkosiec modified the milestones: v1.5.0, v1.7.0 Oct 10, 2023
@josefkarasek
Copy link

Summary from dogfooding in original issue.

@pkosiec pkosiec removed this from the v1.7.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants