Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for k8s.io/docs/concepts/policy/limit-range/ #46899

Open
vsagar100 opened this issue Jun 20, 2024 · 13 comments · May be fixed by #48766
Open

Improvement for k8s.io/docs/concepts/policy/limit-range/ #46899

vsagar100 opened this issue Jun 20, 2024 · 13 comments · May be fixed by #48766
Assignees
Labels
language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@vsagar100
Copy link

vsagar100 commented Jun 20, 2024

LimitRange is namespace specific, however the given example does not contain namespace attribute. I know it will pick default namespace however mentioning it will be more clear & helpful for beginners like me.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 20, 2024
@thisisharrsh
Copy link
Contributor

/language en
/sig docs

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 20, 2024
@thisisharrsh
Copy link
Contributor

thisisharrsh commented Jun 20, 2024

Mentioning the namespace in a LimitRange object can improve the clarity.
Page related to the issue: https://kubernetes.io/docs/concepts/policy/limit-range/
/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 20, 2024
@sftim
Copy link
Contributor

sftim commented Jun 20, 2024

We can also add a comment into the manifest about the namespace being implied. Using a comment helps people test things out in namespaces other than default.

@Shubhdeep02
Copy link

Hey @vsagar100 I think It's already mentioned clearly about the constraints and the steps of using it in LimitRange
object, and you can also take help from the docs for more understanding:
https://kubernetes.io/docs/tasks/administer-cluster/namespaces/

@vsagar100
Copy link
Author

Hey @vsagar100 I think It's already mentioned clearly about the constraints and the steps of using it in LimitRange object, and you can also take help from the docs for more understanding: https://kubernetes.io/docs/tasks/administer-cluster/namespaces/

@Shubhdeep02, I am talking about the below page. It might have been mentioned on the page you mentioned. I was following LimitRange page but found it missing hence requested update.
Page Link: https://kubernetes.io/docs/concepts/policy/limit-range/

@subhals
Copy link

subhals commented Jul 4, 2024

/assign

@T-Lakshmi
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2024
@T-Lakshmi
Copy link
Contributor

PR working on this #46950

@T-Lakshmi
Copy link
Contributor

@subhals,
Are you still working on this issue? if not i can take this up.

@subhals subhals removed their assignment Nov 13, 2024
@subhals
Copy link

subhals commented Nov 13, 2024

@T-Lakshmi Thank you! Please feel free to pull since I am not working on this.

@T-Lakshmi
Copy link
Contributor

@subhals,
Thanks for the confirmation, i will soon open PR for this.

@T-Lakshmi
Copy link
Contributor

/assign

@T-Lakshmi T-Lakshmi linked a pull request Nov 19, 2024 that will close this issue
@T-Lakshmi
Copy link
Contributor

PR Raised #48766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
7 participants