Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: New integration for etcd-io/etcd #5231

Closed
ivanvc opened this issue Oct 24, 2024 · 9 comments
Closed

REQUEST: New integration for etcd-io/etcd #5231

ivanvc opened this issue Oct 24, 2024 · 9 comments
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps

Comments

@ivanvc
Copy link
Member

ivanvc commented Oct 24, 2024

Organization or Repo

etcd-io/etcd

Name of integration

Codecov

Link to integration website

github.com/apps/codecov

Describe what is attempting to be accomplished

We already had the Codecov integration, and it used to work fine. But it recently started showing a warning when it comments on pull requests:

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

At the bottom, it says:

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Refer to a recent comment, i.e., etcd-io/etcd#18767 (comment)

Would it be possible to install the Codecov GitHub app, so we don't get the warning?

Additional context for request

No response

@ivanvc ivanvc added the area/github-integration Third-party integrations, webhooks, or GitHub Apps label Oct 24, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Nov 19, 2024

@MadhavJivrajani, would you be able to help us with this request? Thanks!

@Priyankasaggu11929
Copy link
Member

@ivanvc, could you please provide a list of repos under etcd-io org that require installing codecov app? Thanks!
(we want to avoid installing it org-wide since it includes all future etcd-io org repos as well)

@ivanvc
Copy link
Member Author

ivanvc commented Nov 22, 2024

Hi, @Priyankasaggu11929. At this moment we only want it for the etcd repository. Thank you!

@Priyankasaggu11929
Copy link
Member

Thank you @ivanvc.

I've installed the codecov app for etcd-io/etcd repo:

image
image

@ivanvc
Copy link
Member Author

ivanvc commented Nov 22, 2024

Thanks, @Priyankasaggu11929 🙇. I'll verify that we don't have the warning anymore as soon as we get a new pull request.

@Priyankasaggu11929
Copy link
Member

yes, let's keep this issue open until we have verified. Thank you! :)

@ivanvc
Copy link
Member Author

ivanvc commented Nov 23, 2024

@Priyankasaggu11929, it works as expected, the warning is gone (i.e., etcd-io/etcd#18939 (comment)). Thank you! 🙇

@Priyankasaggu11929
Copy link
Member

Thanks for the confirmation.

/close

@k8s-ci-robot
Copy link
Contributor

@Priyankasaggu11929: Closing this issue.

In response to this:

Thanks for the confirmation.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps
Projects
None yet
Development

No branches or pull requests

3 participants