remove unmaintained storage-provisioner-gluster addon

[nixpanic]

The Gluster project has not has a release in a few years, maintenance slowed down to the point it is almost standing still. Heketi as component for deploying parts of the storage platform has been archived in 2023.

Providing the storage-provisioner-gluster addon might give users the wrong expectations. There is no guarantee Gluster is working with recent minikube versions.

Migration away from GlusterFS

The last minikube release that contains the storage-provisioner-gluster addon is minikube v1.36.0. Because both the plugin and Gluster itself have not seen much maintenance, there is no guarantee that it works.

It is recommended to move data from Gluster PersistentVolumes to an other storage platform before upgrading to minikube v1.37. In order to do so, use a minikube version (<= 1.36) that contained the addon.

---

Updates: #20369

[minikube-bot]

Can one of the admins verify this patch?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[nixpanic]

/remove-lifecycle stale

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nixpanic
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nixpanic]

/retest

Jobs failed immediately while setting up Go.

[nirs]

@nixpanic do we have anything in the iso to support gluster that can be removed as well?

I see you already handled it.

[nixpanic]

@medyagh, do you have an opinion on removing the addon? Is it needed to report a deprecation message to users first (how? got an example?).

Thanks!

[nirs]

@medyagh gluster seems to be the reason why the iso build requires python2, which blocks us from moving to more modern build environment (24.04, Fedora, ...).

[wt]

I looked over the change. Seems more or less reasonable. Looks like it needs a rebase. Is @nixpanic able to do that?

[wt]

FWIW, gluster is dead. I would just remove all traces of it and maybe add a changelog for the fact that gluster was dropped and that you can continue to use older releases if you need to finish a migration.

[wt]

@nixpanic Can you please add an entry to the changelog indicating that gluster was removed and whatever the latest version is that supports it can be used to finish any kind of migration off of it?

[nixpanic]

@nixpanic Can you please add an entry to the changelog indicating that gluster was removed and whatever the latest version is that supports it can be used to finish any kind of migration off of it?

Thanks for the suggestion, but I am not sure where to place it. The changelog seems to be generated from the merged PRs. I'll update the title of this PR a bit, and leave a message about migration in the description.

[nirs]

ok-to-build-iso

[nirs]

Looks good to me. Need to wait for the iso build and run the tests with the new iso.

[minikube-bot]

Hi @nixpanic, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

[nixpanic]

I'm going to rebase this, and drop the iso-update commit (as that has the conflict). Tests with the iso that is built from this PR look good. A screenshot for the archives:

[nirs]

Fixex #21441

[nirs]

@nixpanic we still build glusters as part of the iso. This package requires python2 so we must build the issue on Ubuntu 22.04.

% git grep GLUSTER
deploy/iso/minikube-iso/package/gluster/Config.in:config BR2_PACKAGE_GLUSTER
deploy/iso/minikube-iso/package/gluster/gluster.mk:GLUSTER_VERSION = 4.1.5
deploy/iso/minikube-iso/package/gluster/gluster.mk:GLUSTER_SITE = https://download.gluster.org/pub/gluster/glusterfs/01.old-releases/4.1/$(GLUSTER_VERSION)
deploy/iso/minikube-iso/package/gluster/gluster.mk:GLUSTER_SOURCE = glusterfs-$(GLUSTER_VERSION).tar.gz
deploy/iso/minikube-iso/package/gluster/gluster.mk:GLUSTER_CONF_OPTS = --disable-tiering --disable-ec-dynamic --disable-xmltest --disable-crypt-xlator --disable-georeplication --disable-ibverbs --disable-glupy --disable-gnfs --disable-cmocka --without-server
deploy/iso/minikube-iso/package/gluster/gluster.mk:GLUSTER_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install

Do we have any reason to keep building gluster in the iso?