Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubetail to addons registry #20345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amorey
Copy link

@amorey amorey commented Feb 2, 2025

This PR adds kubetail (https://github.com/kubetail-org/kubetail) to the addons registry.

Add kubetail to addons registry.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @amorey!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @amorey. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amorey
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@amorey
Copy link
Author

amorey commented Feb 4, 2025

@spowelljr @ComradeProgrammer Just checking in! Would it be possible to take a look at this PR soon? I added an addon so most of the diff is from new yaml files.

@medyagh
Copy link
Member

medyagh commented Feb 4, 2025

@amorey thanks for the PR do u mind posting an example of using this addon and what it is for?

@medyagh
Copy link
Member

medyagh commented Feb 4, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2025
@amorey
Copy link
Author

amorey commented Feb 4, 2025

@medyagh Kubetail is a logging dashboard for Kubernetes that lets you view multiple log streams simultaneously in the same timeline. Once it's installed in a cluster you can access the dashboard website through a service (e.g. minikube service -n kubetail-system kubetail-dashboard).

Here's a screenshot:
b37a6ca2-75b8-416a-a2e4-653c67f7fadd

Here's a video:
https://www.youtube.com/watch?v=zyML-Pg12vw

Here's a live demo:
https://demo.kubetail.com

And here's the repo:
https://github.com/kubetail-org/kubetail

Let me know if there's something else I can explain! Is there somewhere in particular I should post examples to?

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20345) |
+----------------+----------+---------------------+
| minikube start | 50.6s    | 51.5s               |
| enable ingress | 17.4s    | 16.4s               |
+----------------+----------+---------------------+

Times for minikube start: 50.3s 49.8s 51.0s 52.4s 49.6s
Times for minikube (PR 20345) start: 51.4s 53.3s 49.4s 51.2s 52.0s

Times for minikube ingress: 19.0s 15.0s 15.0s 19.0s 19.0s
Times for minikube (PR 20345) ingress: 14.5s 15.5s 15.0s 18.5s 18.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20345) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 23.2s               |
| enable ingress | 12.3s    | 12.9s               |
+----------------+----------+---------------------+

Times for minikube start: 20.2s 23.9s 24.2s 20.5s 20.5s
Times for minikube (PR 20345) start: 23.6s 24.8s 20.5s 22.7s 24.2s

Times for minikube ingress: 12.3s 12.3s 12.3s 12.3s 12.3s
Times for minikube (PR 20345) ingress: 12.8s 12.8s 12.8s 12.8s 13.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20345) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 21.1s               |
| enable ingress | 35.8s    | 38.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 19.2s 22.8s 20.0s 21.0s
Times for minikube (PR 20345) start: 23.1s 20.4s 19.7s 22.9s 19.4s

Times for minikube ingress: 38.8s 38.8s 39.3s 38.8s 23.3s
Times for minikube (PR 20345) ingress: 38.8s 38.8s 38.8s 39.0s 39.3s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_docker_arm64 (1 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 0.00% (chart)
KVM_Linux_crio (1 failed) TestAddons/parallel/CSI(gopogh) 14.00% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@amorey
Copy link
Author

amorey commented Feb 5, 2025

Are these test failures expected? Do I need to apply a fix to this PR? I ran the tests locally and got some errors but they're present in the master too:

FAIL	k8s.io/minikube/deploy/minikube	600.195s
FAIL	k8s.io/minikube/test/stress	600.116s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants