From bd82a28f02722b803f10f5d5435fb1b16f575c4d Mon Sep 17 00:00:00 2001 From: Medya Ghazizadeh Date: Mon, 9 Sep 2024 11:11:17 -0700 Subject: [PATCH] Disallow using Docker Desktop 4.34.0 on macos (#19576) * Disallow using Docker Desktop 4.34.0 on macos * Disallow using Docker Desktop 4.34.0 on macos * remove unneeded changes * remove unneeded changes * update changelog --- CHANGELOG.md | 2 +- pkg/minikube/registry/drvs/docker/docker.go | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ac3cbd85b57a..170cdac66b7d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ Breaking Changes: * Bump minimum podman version to 4.9.0 [#19457](https://github.com/kubernetes/minikube/pull/19457) - +* Disallow using Docker Desktop 4.34.0 Features: * Bump default Kubernetes version to v1.31.0 [#19435](https://github.com/kubernetes/minikube/pull/19435) * Add new driver for macOS: vfkit [#19423](https://github.com/kubernetes/minikube/pull/19423) diff --git a/pkg/minikube/registry/drvs/docker/docker.go b/pkg/minikube/registry/drvs/docker/docker.go index 9d5b11424618..89f5da5617fa 100644 --- a/pkg/minikube/registry/drvs/docker/docker.go +++ b/pkg/minikube/registry/drvs/docker/docker.go @@ -289,6 +289,17 @@ func checkDockerDesktopVersion(version string) (s registry.State) { Fix: "Update Docker Desktop to 4.16.1 or greater", } } + + if runtime.GOOS == "darwin" && currSemver.EQ(semver.MustParse("4.34.0")) { + return registry.State{ + Reason: "PROVIDER_DOCKER_DESKTOP_VERSION_BAD", + Running: true, + Error: errors.New("Docker Desktop 4.34.0 has a regression that prevents minikube from listing the containers"), + Installed: true, + Fix: "Use a different Docker desktop version, more info at https://github.com/docker/cli/issues/5412", + } + } + return s }