Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider Stable Metrics Approach via CLI flag #2310

Open
mrueg opened this issue Jan 26, 2024 · 1 comment
Open

Reconsider Stable Metrics Approach via CLI flag #2310

mrueg opened this issue Jan 26, 2024 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mrueg
Copy link
Member

mrueg commented Jan 26, 2024

What would you like to be added:

A way to allow stable metrics to change without increasing major version of KSM.

Why is this needed:

Stable metrics are an impediment to create alignment between all metrics and stop us from making progress in unifying the metric naming, labels etc.
It's understandable that due to the fact, that Prometheus ecosystem has a poorly defined metrics lifecycle, customers want some stability.

Describe the solution you'd like

We should have a CLI flag --stable-metrics=v2 which can be used to enforce stability if the user wants that. This can be used to create stable metrics in the individual metric collectors, while allowing us to move on with better names and better metrics at the same time.
.
Additional context

@mrueg mrueg added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 26, 2024
@dashpole
Copy link

/assign @dgrisonnet
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants