Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error output of git commands #1958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve error output of git commands #1958

wants to merge 1 commit into from

Conversation

cortex3
Copy link

@cortex3 cortex3 commented Nov 7, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

improves error output of git commands see #1957 for context.
Example:
current output:

FATA initBuildConfig failed: clibuildconfig cannot be created due to error in creating build context, getAbsBuildContext failed: exit status 128

with my PR:

FATA initBuildConfig failed: clibuildconfig cannot be created due to error in creating build context, getAbsBuildContext failed: fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Which issue(s) this PR fixes:

Fixes #1957

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cortex3
Once this PR has been reviewed and has the lgtm label, please assign tessaio for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @cortex3!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 7, 2024
cdrage
cdrage requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a unit test, is there any way you can possibly do a simple one for utils_test.go?

Otherwise, the code looks great! :)

@cortex3
Copy link
Author

cortex3 commented Nov 14, 2024

Hi @cdrage,
I noticed that there are already unit tests for the openshift utils.go. They are just a bit hidden away because they have been included in the openshift_test.go:

kompose/pkg/transformer/openshift/openshift_test.go

Line 256 in 922f5aa

func TestGetAbsBuildContext(t *testing.T) {

The tests are still passing but let me know if you want me to extend them in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage requested changes

@TessaIO TessaIO Awaiting requested review from TessaIO

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] kompose fails with getAbsBuildContext failed: exit status 128
3 participants
@cortex3 @k8s-ci-robot @cdrage